Re: [PATCH 33/33] blk-throttle: implement proper hierarchy support

From: Tejun Heo
Date: Tue May 07 2013 - 12:14:23 EST


Hello, Vivek.

On Tue, May 07, 2013 at 09:55:11AM -0400, Vivek Goyal wrote:
> So if somebody does not specify __DEVEL_sane_behavior, hierarchy is
> still broken. Should we continue to display the message in that case?

The message is to warn people of possible behavior changes. For
blk-throttle, the behaviors are settled now. Whetner sane_behavior or
not, the hierarchy behaviors aren't gonna change anymore. The
hindsight is 20/20 and it would probably have been better if we had
done the same for cfq but I was thinking that we could probably do
away with interface versioning at the time. Ah well... it isn't
optimal but that's what we ended up with.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/