Re: [PATCH 0/5] drivers: bus: omap_l3: Conversion to devm_*

From: Santosh Shilimkar
Date: Tue May 07 2013 - 08:51:50 EST


On Thursday 02 May 2013 05:39 PM, Peter Ujfalusi wrote:
> Hi,
>
> Cleanup of platform probe and remove (removing the remove function at the end)
> with converting the driver to use the devm_* versions kzalloc, ioremap and
> request_irq.
>
Thanks Peter. All patches looks fine to my eyes. In the last patch wher
you are changing the error level is bit debatable but I agree with you.

So FWIW,
Reviewed-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>


> Peter Ujfalusi (5):
> drivers: bus: omap_l3: Convert to use devm_kzalloc
> drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()
> drivers: bus: omap_l3: Convert to use devm_request_irq()
> drivers: bus: omap_l3: Remove the platform driver's remove function
> drivers: bus: omap_l3: Change pr_crit() to dev_err() when IRQ request
> fails
>
> drivers/bus/omap_l3_noc.c | 106 +++++++++++-----------------------------------
> 1 file changed, 24 insertions(+), 82 deletions(-)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/