Re: [PATCH 29.5/32] blk-throttle: add throtl_qnode for dispatchfairness

From: Vivek Goyal
Date: Mon May 06 2013 - 12:24:15 EST


On Fri, May 03, 2013 at 05:50:44PM -0700, Tejun Heo wrote:

[..]
> + * qnode_on_self is used when bios are directly queued to this
> + * throtl_grp so that local bios compete fairly with bios
> + * dispatched from children. qnode_on_parent is used when bios are
> + * dispatched from this throtl_grp into its parent and will compete
> + * with the sibling qnode_on_parents and the parent's
> + * qnode_on_self.
> + */
> + struct throtl_qnode qnode_on_self;
> + struct throtl_qnode qnode_on_parent;

Do we need one throtl_qnode for each IO dir (read/write) so that we can
queue up the right direction throtl_node in right sq->queued[rw].

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/