Re: [PATCH] ata: increase retry count but shorten duration forCalxeda controller

From: Timur Tabi
Date: Mon May 06 2013 - 11:45:51 EST


On Wed, May 1, 2013 at 4:34 PM, Mark Langsdorf
<mark.langsdorf@xxxxxxxxxxx> wrote:
>
> - const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context);
> + unsigned long timing[] = { 5, 100, 500};


Why are you dropping the 'const'?

Assuming it works, this should be more efficient:

static const unsigned long timing[] = {5, 100, 500};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/