Re: Add missing module license tag to vring helpers.

From: Rusty Russell
Date: Mon May 06 2013 - 03:55:17 EST


Dave Jones <davej@xxxxxxxxxx> writes:
> [ 624.286653] vringh: module license 'unspecified' taints kernel.
>
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>

Thanks! This is exactly right.

But note that the default license tag for otherwise-unlabelled modules
would be "GPLv2". "GPL" means v2 or later (which is what I want, but
it's not the kernel default).

Applied,
Rusty.

> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
> index bff0775..5174eba 100644
> --- a/drivers/vhost/vringh.c
> +++ b/drivers/vhost/vringh.c
> @@ -3,6 +3,7 @@
> *
> * Since these may be in userspace, we use (inline) accessors.
> */
> +#include <linux/module.h>
> #include <linux/vringh.h>
> #include <linux/virtio_ring.h>
> #include <linux/kernel.h>
> @@ -1005,3 +1006,5 @@ int vringh_need_notify_kern(struct vringh *vrh)
> return __vringh_need_notify(vrh, getu16_kern);
> }
> EXPORT_SYMBOL(vringh_need_notify_kern);
> +
> +MODULE_LICENSE("GPL");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/