[PATCH v2 1/2] f2fs: Continue to mount after failing recovery

From: Chris Fries
Date: Thu May 02 2013 - 17:04:23 EST



From: Chris Fries <C.Fries@xxxxxxxxxxxx>

When unable to roll forward the journal, we shouldn't bail out and
not mount, we should continue to attempt the mount. Bad recovery data
is likely unrecoverable at this point, and requiring the user to try
to mount again doesn't solve any issues.

Signed-off-by: Chris Fries <C.Fries@xxxxxxxxxxxx>
Reviewed-by: Russell Knize <rknize2@xxxxxxxxxxxx>
Reviewed-by: Jason Hrycay <jason.hrycay@xxxxxxxxxxxx>
---
fs/f2fs/super.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 2643c49..d8f7ed3 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -649,10 +649,9 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
/* recover fsynced data */
if (!test_opt(sbi, DISABLE_ROLL_FORWARD)) {
err = recover_fsync_data(sbi);
- if (err) {
- f2fs_msg(sb, KERN_ERR, "Failed to recover fsync data");
- goto free_root_inode;
- }
+ if (err)
+ f2fs_msg(sb, KERN_ERR,
+ "Cannot recover all fsync data, continue\n");
}

/* After POR, we can run background GC thread */
--
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/