Re: [PATCH, RFC 10/22] mfd: ab8500: debugfs code depends on gpadc

From: Lee Jones
Date: Thu May 02 2013 - 11:36:33 EST


On Thu, 02 May 2013, Arnd Bergmann wrote:

> The AB8500_DEBUG code specifically requires access to the gpadc code,
> not just the common ab8500 driver.
>
> drivers/built-in.o: In function `ab8500_gpadc_bat_ctrl_print':
> mfd/ab8500-debugfs.c:1733: undefined reference to `ab8500_gpadc_get'
> mfd/ab8500-debugfs.c:1734: undefined reference to `ab8500_gpadc_read_raw'
> mfd/ab8500-debugfs.c:1736: undefined reference to `ab8500_gpadc_ad_to_voltage'
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Philippe LANGLAIS <philippe.langlais@xxxxxxxxxxxxxx>
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 9b4703e..bf785db 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -580,7 +580,7 @@ config AB8500_CORE
>
> config AB8500_DEBUG
> bool "Enable debug info via debugfs"
> - depends on AB8500_CORE && DEBUG_FS
> + depends on AB8500_GPADC && DEBUG_FS
> default y if DEBUG_FS
> help
> Select this option if you want debug information using the debug

Did you find this with ALLCONFIG out of interest.

Applied by the way.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/