Re: [PATCH RESEND v5] fat: editions to support fat_fallocate

From: Namjae Jeon
Date: Thu May 02 2013 - 05:56:24 EST


2013/5/2, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>:
> Namjae Jeon <linkinjeon@xxxxxxxxx> writes:
>
>>>> AFAIK, preallocation != fallocate. ext*'s preallocation was there at
>>>> before fallocation to optimize block allocation for user data blocks.
>> yes, this is correct , preallocation!= fallocate, we just adopted only
>> the "release part" from that approach
>> Sorry, Would you mind to adopt this approach :) ?
>
> I'm ok as start if it works.
>
> But from this discussion, discard at last close(2) doesn't look like
> working for your requirement. Since you want to discard at last close of
> inode, so, rather, I guess you actually want to discard at last
> dereference of inode.
Okay, I see. I will check your review points again.

Thanks OGAWA for review!
>
> Thanks.
> --
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/