Re: [PATCH 1/4] mmzone: make holding lock_memory_hotplug() arequirement for updating pgdat size

From: David Rientjes
Date: Wed May 01 2013 - 18:26:46 EST


On Wed, 1 May 2013, Cody P Schafer wrote:

> All updaters of pgdat size (spanned_pages, start_pfn, and
> present_pages) currently also hold lock_memory_hotplug() (in addition
> to pgdat_resize_lock()).
>
> Document this and make holding of that lock a requirement on the update
> side for now, but keep the pgdat_resize_lock() around for readers that
> can't lock a mutex.
>
> Signed-off-by: Cody P Schafer <cody@xxxxxxxxxxxxxxxxxx>

Nack, these fields are initialized at boot without lock_memory_hotplug(),
so you're statement is wrong, and all you need is pgdat_resize_lock().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/