Re: [PATCH] x86, mce: Print warning if MCE handler fails to register/dev/mcelog

From: Borislav Petkov
Date: Tue Apr 09 2013 - 14:54:30 EST


On Tue, Apr 09, 2013 at 06:30:58PM +0000, Luck, Tony wrote:
> - misc_register(&mce_chrdev_device);
> + if (misc_register(&mce_chrdev_device) != 0)
> + pr_warn("Failed to register mcelog device\n");
>
> Did this actually happen to you? Or is this just "good practice" to check the
> return value from misc_register?

I'm very sceptical this actually happens - we would've otherwise seen
reports about mcelog not starting correctly.

Hmm.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/