Re: [PATCH v2] pwm: spear: Fix enable pwm output

[Shiraz Hashim]

On Sat, Mar 30, 2013 at 05:55:41PM +0800, Viresh Kumar wrote:
> On 30 March 2013 11:07, Axel Lin <axel.lin@xxxxxxxxxx> wrote:
> > The logic to check return value of clk_enable() is reversed, thus
> > when clk_enable() passes PWMCR_PWM_ENABLE bit is not set. Fix it.
> >
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> > ---
> >  drivers/pwm/pwm-spear.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> I am so sorry. clk_prepare also has the same issue :(
> Please fix that too and i will ack it ASAP.
> 
> @Shiraz: Any idea how they went through?

I don't remember how :(, surely a mistake which escaped tests also.

--
regards
Shiraz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/