Re: [char-misc-next 08/11 V5] mei: nfc: Initial nfc implementation

[Samuel Ortiz]

Hi Greg,

On Fri, Mar 29, 2013 at 08:48:23AM -0700, Greg KH wrote:
> On Wed, Mar 27, 2013 at 05:30:00PM +0200, Tomas Winkler wrote:
> > --- /dev/null
> > +++ b/drivers/misc/mei/nfc.h
> > @@ -0,0 +1,122 @@
> > +/******************************************************************************
> > + * Intel Management Engine Interface (Intel MEI) Linux driver
> > + * Intel MEI Interface Header
> > + *
> > + * This file is provided under a dual BSD/GPLv2 license.  When using or
> > + * redistributing this file, you may do so under either license.
> > + *
> > + * GPL LICENSE SUMMARY
> > + *
> > + * Copyright(c) 2003 - 2012 Intel Corporation. All rights reserved.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of version 2 of the GNU General Public License as
> > + * published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful, but
> > + * WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> > + * General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110,
> > + * USA
> > + *
> > + * The full GNU General Public License is included in this distribution
> > + * in the file called LICENSE.GPL.
> > + *
> > + * Contact Information:
> > + *	Intel Corporation.
> > + *	linux-mei@xxxxxxxxxxxxxxx
> > + *	http://www.intel.com
> > + *
> > + * BSD LICENSE
> > + *
> > + * Copyright(c) 2003 - 2012 Intel Corporation. All rights reserved.
> > + * All rights reserved.
> > + *
> > + * Redistribution and use in source and binary forms, with or without
> > + * modification, are permitted provided that the following conditions
> > + * are met:
> > + *
> > + *  * Redistributions of source code must retain the above copyright
> > + *    notice, this list of conditions and the following disclaimer.
> > + *  * Redistributions in binary form must reproduce the above copyright
> > + *    notice, this list of conditions and the following disclaimer in
> > + *    the documentation and/or other materials provided with the
> > + *    distribution.
> > + *  * Neither the name Intel Corporation nor the names of its
> > + *    contributors may be used to endorse or promote products derived
> > + *    from this software without specific prior written permission.
> > + *
> > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> > + *
> > + *****************************************************************************/
> 
> How is your .h file dual licensed, and yet, the .c file is gpl2 only?
> 
> Please fix this by not even having this .h file, it's not needed.
The structures and commands defined in nfc.h may be used by pure userspace NFC
stacks (e.g. the Android ones) and I don't want them to be defined under a GPL
only license (Even though some will say structure and command definitions are
not copyrighteable). Would it be fine with you if I'd put those definitions
under include/uapi/linux/mei.h ?

> > +struct mei_nfc_cmd {
> > +	uint8_t command;
> > +	uint8_t status;
> > +	uint16_t req_id;
> > +	uint32_t reserved;
> > +	uint16_t data_size;
> > +	uint8_t sub_command;
> > +	uint8_t data[];
> > +} __packed;
> 
> Use "real" Linux kernel data types, not these cruddy userspace ones
> (i.e. u8, u16, etc.)
Will fix that.

 
> I've applied the patches prior to this in the series and stopped here,
Thanks.


> so feel free to redo the rest of them and resend.
I will do so in the next days.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/