Re: [PATCH 1/1] TTY Fix NULL pointer error in tty_wakeup

[Greg Kroah-Hartman]

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top


On Sun, Mar 31, 2013 at 04:09:05PM +0800, frankie lin wrote:
> Hi, greg, it's excited to get your reply.
> In our case, it is gs_start_io(struct gs_port *port) in the file u_serial.c who
> call the tty_wakeup. We are trying to find the root cause.  Something is wrong
> before calling tty_wakeup, nevertheless it is reasonable to check the parameter
> first before test_bit.

No, please find the root problem here in your driver.

> To some extent, this patch can improve the robustness of function tty_wakeup,
> isn't it?

Not at the expense of papering over other bugs, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/