Re: [PATCH] PCI, ACPI: Don't query OSC support with all possible controls

[Yinghai Lu]

On Fri, Mar 29, 2013 at 5:36 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
>> -             /* Run _OSC query for all possible controls. */
>> -             capbuf[OSC_CONTROL_TYPE] = OSC_PCI_CONTROL_MASKS;
>> +             /* Run _OSC query only with existing controls. */
>> +             capbuf[OSC_CONTROL_TYPE] = root->osc_control_set;
>
> I suppose we can do that, but then why this should be root->osc_control_set and
> not just 0?

in case query support and set control are called in mixed sequence.

And ACPI spec says if control set and can not be revoked.

also when it control is passed, it is always OR with root->os_control_set.
    capbuf[OSC_CONTROL_TYPE] = *control | root->osc_control_set;


Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/