Re: [PATCH 07/33] regulator: ab8500-ext: Add suspend support

[Mark Brown]

On Thu, Mar 28, 2013 at 04:11:07PM +0000, Lee Jones wrote:

> +static int ab8500_ext_regulator_set_suspend_enable(struct regulator_dev *rdev)
> +{
> +	dev_dbg(rdev_get_dev(rdev), "suspend: ");

It's kind of a general problem with the AB8500 code but there's an awful
lot of content free trace like this, if there's not adequate trace in
the core for things like that we should add it there.

> +
> +	return ab8500_ext_regulator_enable(rdev);
> +}
> +

This looks broken - it's going to interfere with the normal runtime
operation of the device as it's using exactly the same operation to
change the device state.  If the hardware doesn't have any support for
suspend mode then the driver shouldn't be implementing this function.

Attachment: signature.asc
Description: Digital signature