Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as__maybe_unused

[Alan Stern]

On Thu, 28 Mar 2013, Arnd Bergmann wrote:

> Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used
> with CONFIG_PM" tried to hide the unlink_empty_async_suspended function
> inside of an #ifdef to work around an unused function warning.
> 
> Unfortunately that had the effect of introducing a new warning:
> 
> drivers/usb/host/ehci-q.c:1297:13: warning: 'unlink_empty_async_suspended' 
> 	declared 'static' but never defined [-Wunused-function]
> 
> While we could add another #ifdef around the function declaration to avoid
> this, a nicer solution is to mark it as __maybe_unused, which will let
> gcc silently drop the function definition when it is not needed.

IMO the compiler is being stupid.  -Wunused-function should warn 
about functions that are defined but not called, not about functions 
that are declared but not defined.  Grumble...

Anyway yes, this is a good fix.

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/