Re: [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4

[Sebastian Hesselbarth]

On 03/28/2013 07:14 PM, Russell King - ARM Linux wrote:
> On Thu, Mar 28, 2013 at 01:06:54PM -0400, Jason Cooper wrote:
> > On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote:
> > > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using
> > > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable
> > > iWMMXt extensions on Dove.
> > >
> > > Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@xxxxxxxxx>
> > > ---
> > > Cc: Russell King<linux@xxxxxxxxxxxxxxxx>
> > > Cc: Jason Cooper<jason@xxxxxxxxxxxxxx>
> > > Cc: Andrew Lunn<andrew@xxxxxxx>
> > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > > ---
> > >   arch/arm/Kconfig |    2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Hmmm, I'm getting (with dove_defconfig):
> >
> > arch/arm/kernel/built-in.o: In function `iwmmxt_do':
> > /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release'
> > /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch'
> > make: *** [vmlinux] Error 1
>
> Looks to me like PJ4 IWMMXT support wasn't properly tested out when it
> was submitted - it's possible to end up with pj4-cp0.c built without
> the IWMMXT code that it depends on being built...

Russel, Jason,

do we force iWMMXt on CPU_PJ4 or should there be some #ifdef'ery if 
IWMMXT is not selected?

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/