Re: [PATCH 1/2] eisa, PCI: Fix bus res reference

[Bjorn Helgaas]

On Thu, Mar 28, 2013 at 9:16 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Thu, Mar 28, 2013 at 5:52 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>> On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>>> Matthem found that 3.8.3 is having problems with an old (ancient)
>>> PCI-to-EISA bridge, the Intel 82375. It worked with the 3.2 kernel.
>>> He identified the 82375, but doesn't assign the struct resource *res
>>> pointer inside the struct eisa_root_device, and panics.
>>>
>>> After looking at pci_eisa_init(), found it referring bus resource
>>> directly instead of pci_bus_resource_n().
>>>
>>> After commit 45ca9e97 (PCI: add helpers for building PCI bus resource lists)
>>> and commit 0efd5aab (PCI: add struct pci_host_bridge_window with CPU/bus
>>> address offset), bus->resource[] is not used for pci root bus any more.
>>>
>>> Fix it by using pci_bus_resource_n() and correct idx for root bus.
>>
>> Please include URLs for the problem reports for these problems
>> (bugzilla or mailing list discussion).
>
> Matthew sent private mail to me, and I sent him test patch to see
> if it fixes the problem. then I posted patches here after that.

Please add "cc: linux-pci@xxxxxxxxxxxxxxx" when you respond to private
mail like that.  As far as I'm concerned, if it doesn't appear in a
public email archive, it didn't happen.  I hate dealing with patches
out of the blue like this that don't have any context.  If it's on a
mailing list, other people with the same problem have some hope of
finding this solution.

>>> Reported-by: Matthew Whitehead <mwhitehe@xxxxxxxxxx>
>>> Tested-by: Matthew Whitehead <mwhitehe@xxxxxxxxxx>
>>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>>> Cc: stable@xxxxxxxxxx
>>
>> You are consistently using the wrong stable email address.  It should
>> be "stable@xxxxxxxxxxxxxxx".  I assume you see a bounce every time; at
>> least, I get a bounce when I reply to your messages.
>
> I thought that is tag only, and stable maintainer  will search that from
> Linus's tree.
> but git send-mail will pick up Cc from the patch.
>
> So stable@xxxxxxxxxx will never get fixed?

What's to fix?  The doc (Documentation/stable_kernel_rules.txt) says
to use "Cc: stable@xxxxxxxxxxxxxxx" and using "Cc: stable@xxxxxxxxxx"
causes bounces.  Just use the documented address like everybody else
and everything will be fine.

If you want "stable@xxxxxxxxxx" to work, first make the kernel.org
change, then change Documentation/stable_kernel_rules.txt, *then*
start using it in your patches.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/