Re: [PATCH] arm: omap: RX-51: ARM errata 430973 workaround

From: Tony Lindgren
Date: Thu Mar 28 2013 - 11:53:42 EST


* Santosh Shilimkar <santosh.shilimkar@xxxxxx> [130328 03:10]:
> On Thursday 28 March 2013 03:20 PM, Russell King - ARM Linux wrote:
> > On Wed, Mar 27, 2013 at 01:56:07PM -0700, Tony Lindgren wrote:
> >> * Pali RohÃr <pali.rohar@xxxxxxxxx> [130324 07:31]:
> >>> it is possible to upstream errata 430973 workaround for RX-51?
> >>
> >> I think we should make the SMC handling a generic function for ARM.
> >>
> >> AFAIK just the SMC call numbering is different for various
> >> implementations. So the handler and passing of the parameters
> >> seems like it should be generic.
> >
> > SMC calls vary greatly in how they are handled. The only thing that's
> > generic is issuing the SMC call. All the setup and what arguments are
> > required are completely different from SoC to SoC.
> >
> > For example, some SoCs require arguments passed via memory. Others like
> > OMAP its via registers.
>
> Exactly. As somebody said on the list, that code looks identical but
> it is not. An SMC with barrier instruction is mostly common and nothing
> more than that.

Thanks all, case closed then. There's no way to come up with a generic
SMC function.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/