Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irqfunction is specified

[Russell King - ARM Linux]

On Thu, Mar 28, 2013 at 03:25:42PM +0000, Arnd Bergmann wrote:
> On Thursday 28 March 2013, Russell King - ARM Linux wrote:
> > Better:
> > 
> > #ifdef CONFIG_OF
> >         if (!machine_desc->init_irq)
> >                 irqchip_init();
> >         else
> > #endif
> >                 machine_desc->init_irq();
> > 
> > which means we don't even get the test if !OF, and if someone mistakenly
> > sets this to NULL for a !OF platform, they get to know about it.
> 
> Right. With the new IS_DEFINED() macro, we could even turn this into
> 
> 	if (IS_DEFINED(CONFIG_OF) && !machine_desc->init_irq)
> 		irqchip_init();
> 	else
> 		machine_desc->init_irq();
> 
> to the same effect.

Provided irqchip_init() keeps its prototype visible, then yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/