Re: [PATCH 2/3] pinctrl: remove superfluous optimization in pinctrl_select_state_locked

From: Stephen Warren
Date: Thu Mar 28 2013 - 10:58:11 EST

Next message: Stephen Warren: "Re: [PATCH 3/3] pinctrl: pinctrl_select_state: set the old_stateback on error"
Previous message: Stephen Warren: "Re: [PATCH 1/3] pinctrl: use dev_info instead of pr_info in pinctrl_select_state_locked"
In reply to: Richard Genoud: "[PATCH 2/3] pinctrl: remove superfluous optimization in pinctrl_select_state_locked"
Next in thread: Richard Genoud: "[PATCH 3/3] pinctrl: pinctrl_select_state: set the old_state back on error"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 03/28/2013 05:55 AM, Richard Genoud wrote:
> As Stephen Warren suggested, checking first if the setting->node entry
> is the first in the list or not is superfluous, as it is checked again
> in the list_for_each_entry bellow.
> So, remove it, the code will be simpler and lighter !

Reviewed-by: Stephen Warren <swarren@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Stephen Warren: "Re: [PATCH 3/3] pinctrl: pinctrl_select_state: set the old_stateback on error"
Previous message: Stephen Warren: "Re: [PATCH 1/3] pinctrl: use dev_info instead of pr_info in pinctrl_select_state_locked"
In reply to: Richard Genoud: "[PATCH 2/3] pinctrl: remove superfluous optimization in pinctrl_select_state_locked"
Next in thread: Richard Genoud: "[PATCH 3/3] pinctrl: pinctrl_select_state: set the old_state back on error"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]