Re: [PATCH 04/33] aio: remove retry-based AIO

From: Theodore Ts'o
Date: Thu Mar 28 2013 - 10:56:46 EST


On Thu, Mar 21, 2013 at 09:35:25AM -0700, Kent Overstreet wrote:
> From: Zach Brown <zab@xxxxxxxxxx>
>
> This removes the retry-based AIO infrastructure now that nothing in tree
> is using it.
>
> We want to remove retry-based AIO because it is fundemantally unsafe. It
> retries IO submission from a kernel thread that has only assumed the mm of
> the submitting task. All other task_struct references in the IO
> submission path will see the kernel thread, not the submitting task. This
> design flaw means that nothing of any meaningful complexity can use
> retry-based AIO.
>
> This removes all the code and data associated with the retry machinery.
> The most significant benefit of this is the removal of the locking around
> the unused run list in the submission path.
>
> This has only been compiled.
>
> Signed-off-by: Kent Overstreet <koverstreet@xxxxxxxxxx>
> Signed-off-by: Zach Brown <zab@xxxxxxxxxx>

Reviewed-by: "Theodore Ts'o" <tytso@xxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/