Re: [PATCH v2 6/6] sctp: convert sctp_assoc_set_id to useidr_alloc_cyclic

From: Neil Horman
Date: Thu Mar 28 2013 - 10:04:28 EST


On Thu, Mar 28, 2013 at 09:53:08AM -0400, Neil Horman wrote:
> On Wed, Mar 27, 2013 at 03:29:38PM -0400, Jeff Layton wrote:
> > (Note: compile-tested only)
> >
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> > Cc: Vlad Yasevich <vyasevich@xxxxxxxxx>
> > Cc: Sridhar Samudrala <sri@xxxxxxxxxx>
> > Cc: Neil Horman <nhorman@xxxxxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: linux-sctp@xxxxxxxxxxxxxxx
> > Cc: netdev@xxxxxxxxxxxxxxx
> > ---
> > net/sctp/associola.c | 16 ++--------------
> > 1 file changed, 2 insertions(+), 14 deletions(-)
> >
> I don't see anything wrong with this patch per-se, but the idr_alloc_cyclic call
> isn't integrated with net/net-next or Linus' tree yet. If we don't gate this
> patch on that integration, we'll break the build.
> Neil
>
Actually, I just noticed that you only sent us 6/6 here, I'm assuming a prior
patch in the series adds the idr_alloc_cyclic code? if so, I've seen the prior
version

Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/