Re: Out-of-bound access in sysrq

[Mathieu Poirier]

On 13-03-28 04:34 AM, Jiri Slaby wrote:
> Guys,
> 
> how is this supposed to work?
> 
> #define SYSRQ_KEY_RESET_MAX     20 /* Should be plenty */
> static unsigned short sysrq_reset_seq[SYSRQ_KEY_RESET_MAX];
> ...
> unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
> ...
> static inline void sysrq_register_handler(void)
> {
> ...
>         for (i = 0; i < ARRAY_SIZE(sysrq_reset_seq); i++) {
>                 key = platform_sysrq_reset_seq[i];
>                 if (key == KEY_RESERVED || key > KEY_MAX)
> ...
> 
> 
> 
> 
> i runs from 0 to 19 incl., but platform_sysrq_reset_seq, if not
> overriden, is of size 1, so?
> 
> thanks,
> 

Unless I'm missing something, 'i' won't go higher than '0' since the
first element of platform_sysrq_reset_seq is set to KEY_RESERVED and in
such case the 'break' is executed.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/