[PATCH 1/3] pinctrl: use dev_info instead of pr_info in pinctrl_select_state_locked

From: Richard Genoud
Date: Thu Mar 28 2013 - 07:56:12 EST


And remove superfluous brackets.

Signed-off-by: Richard Genoud <richard.genoud@xxxxxxxxx>
---
If it's not too late, it can be squashed with commit:
3102a76cfbf9ac4ae0cf54c7452f7ba4292a4760
"pinctrl: disable and free setting in select_state in case of error"

drivers/pinctrl/core.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 9b505acc..b98a275 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -912,9 +912,8 @@ static int pinctrl_select_state_locked(struct pinctrl *p,
break;
}

- if (ret < 0) {
+ if (ret < 0)
goto unapply_new_state;
- }
}

p->state = state;
@@ -922,7 +921,7 @@ static int pinctrl_select_state_locked(struct pinctrl *p,
return 0;

unapply_new_state:
- pr_info("Error applying setting, reverse things back\n");
+ dev_err(p->dev, "Error applying setting, reverse things back\n");

/*
* If the loop stopped on the 1st entry, nothing has been enabled,
--
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/