Re: [PATCH] gpio: palmas: add dt support

[Laxman Dewangan]

On Wednesday 27 March 2013 06:30 PM, Linus Walleij wrote:
> On Thu, Mar 21, 2013 at 3:30 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:
>
> > +#ifdef CONFIG_OF
> > +static struct of_device_id of_palmas_gpio_match[] = {
> > +       { .compatible = "ti,palmas-gpio"},
> > +       { },
> > +};
> > +MODULE_DEVICE_TABLE(of, of_palmas_gpio_match);
> > +#endif
> But please drop the #ifdef here unless it causes compile errors
> (I don't think it will.)

I am using this table as

driver.of_match_table = of_match_ptr(of_palmas_gpio_match),
of_match_ptr is macro which is NULL in case of CONFIG_OF not defined.
So if I remove ifdefs then it may create build warning as unused variable.

Therefore, I think it is require here.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/