Re: [PATCH] kernel/range.c: subtract_range: fix the broken phraseissued by printk

[Lin Feng]

Hi Bjorn and others,

On 03/28/2013 01:27 AM, Bjorn Helgaas wrote:
>> -                               printk(KERN_ERR "run of slot in ranges\n");
>> > +                               pr_err("%s: run out of slot in ranges\n",
>> > +                                       __func__);
>> >                         }
>> >                         range[j].end = start;
>> >                         continue;
> So now the user might see:
> 
>     subtract_range: run out of slot in ranges
> 
> What is the user supposed to do when he sees that?  If he happens to
> mention it on LKML, what are we going to do about it?  If he attaches
> the complete dmesg log, is there enough information to do something?
> 
> IMHO, that message is still totally useless.
> 

Yes, we need to issue some useful message. 
How about dump_stack() there so that we can find some clues more since
subtract_range() is called mtrr_bp_init path and pci relative path, then
it may help to instruct us to do something ;-) ?

thanks,
linfeng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/