Re: [PATCH] power: pass IRQF_ONESHOT to request_threaded_irq()

From: Mark Brown
Date: Wed Mar 27 2013 - 21:06:21 EST


On Thu, Mar 28, 2013 at 02:42:50AM +0200, Andrei Epure wrote:
> Patch found using coccinelle.
>
> Signed-off-by: Andrei Epure <epure.andrei@xxxxxxxxx>

Some of these may be false positives especially for PMICs - often the
interrupts are guaranteed to be generated from the interrupt controller
on the device which runs in thread context.

More generally though why not fix this in request_threaded_irq() itself,
if there's no hard IRQ handler then add the flag transparently? It'd
save boilerplate. Indeed I could've sworn someone did that...

Attachment: signature.asc
Description: Digital signature