Re: [PATCH v2] perf: add callgrind conversion tool

From: Roberto Vitillo
Date: Wed Mar 27 2013 - 13:08:00 EST


On Wed, Mar 27, 2013 at 12:23 AM, Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> Hi Roberto,
>
> On Tue, 26 Mar 2013 12:14:49 -0700, Roberto Vitillo wrote:
>> The proposed patch adds the convert tool to perf which allows to convert a
>> perf.data file to a set of callgrind data files which can subsequently be
>> displayed with kcachegrind.
>>
>> Note that the code may trigger the following bug in libbfd:
>> http://sourceware.org/bugzilla/show_bug.cgi?id=15106
>
> Does it now support call graph too? Great if so!

Yes it does.

> Anyway, I suggest that splitting patch to two - one for addr2line and
> another for actual 'convert' tool.

Ok

> I think we *can* use the tool
> without libbfd (but with external addr2line binary or even with no line
> number information).

Well, I could use the external addr2line binary but the tool will
become terribly slow. A warning message could notify the
user to recompile perf with libbfd to speed up the conversion.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/