Re: [patch 13/34] cris: Use generic idle loop

[Jesper Nilsson]

On Thu, Mar 21, 2013 at 09:53:06PM -0000, Thomas Gleixner wrote:
[snip]
> Index: linux-2.6/arch/cris/arch-v32/kernel/process.c
> ===================================================================
> --- linux-2.6.orig/arch/cris/arch-v32/kernel/process.c
> +++ linux-2.6/arch/cris/arch-v32/kernel/process.c
> @@ -23,12 +23,10 @@ extern void stop_watchdog(void);
>  /* We use this if we don't have any better idle routine. */
>  void default_idle(void)
>  {
> -	local_irq_disable();
> -	if (!need_resched()) {
> -		/* Halt until exception. */
> -		__asm__ volatile("ei    \n\t"
> -				 "halt      ");
> -	}
> +	/* Halt until exception. */
> +	__asm__ volatile("ei    \n\t"
> +			 "halt      ");
> +	/* CHECKME: Is this really needed ?? */
>  	local_irq_enable();

No, that local_irq_enable() is redundant since we already enabled interrupts
in the assembler directive above.

>  }

Looks good,

Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/