Re: [PATCH] scripts/tags.sh: Add magic for OFFSET and DEFINE

[Michal Marek]

On 27.3.2013 12:59, Kirill Tkhai wrote:
> 27.03.2013, 01:35, "Michal Marek" <mmarek@xxxxxxx>:
>> The macro definitions in the asm-offsets.h file are ammended with a
>> comment explaining what the value actually means. So you see both the
>> value and the semantic of the macro:
>>
>> #define TI_flags 16 /* offsetof(struct thread_info, flags)      # */
>>
>> By jumping to the asm-offset.c file instead, you would get only a subset
>> of that information.
>>
>> OFFSET(TI_flags, thread_info, flags);
>>
>> Unless I'm missing something, I don't think that this patch improves
>> much.
> 
> This patch does not annul definitions in asm-offsets.h. They stay still on their places.
> It adds OFFSETs and DEFINEs from asm-offsets.c files.
> 
> When kernel is not precompiled you do not have asm-offsets.h and you are not
> able to see what is the place offsets are defined for yor architecture.
> 
> Also, you are not able to look at other architectures because they do not have
> precompiled asm-offsets.h.

I see, these are valid use cases for the regexps. I applied your patch
to kbuild.git#misc now.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/