Re: [PATCH v3.9+] HID: multitouch: fix touchpad buttons

[Jiri Kosina]

On Fri, 22 Mar 2013, Benjamin Tissoires wrote:

> Commit "HID: multitouch: use the callback "report" instead..." breaks the
> buttons of touchpads following the HID multitouch specification.
> The buttons were emmitted through hid-input, but as now the events
> are generated only in hid-multitouch, the buttons are not emmitted anymore.
> 
> The input_event() call is far much simpler than the hid-input one as
> many of the different tests do not apply to multitouch touchpads.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> ---
> 
> Hi guys,
> 
> really sorry for that. I forgot that I had in one of my drawer of my desk one
> prototype of a touchpad following the multitouch specification, but with
> two physical buttons. And of course, I did not put it in my database, meaning
> that the support has been broken in the patches already in 3.9.
> 
> I don't think it's a big deal (to my knowledge, no retail product uses this
> feature), but it's still a regression in 3.9.

I am queuing this for 3.9 still, thanks.

Benjamin, just please double-check that the patch is ok as-is in my 
for-3.9/upstream-fixes branch, as I had to hand-apply it due to 
context-related conflicts.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/