Re: [char-misc-next 01/11 V4] mei: bus: Initial MEI Client bus typeimplementation

[Greg KH]

On Tue, Mar 26, 2013 at 02:33:26PM +0100, Samuel Ortiz wrote:
> > > +/**
> > > + * struct mei_cl_device - MEI device handle
> > > + * An mei_cl_device pointer is returned from mei_add_device()
> > > + * and links MEI bus clients to their actual ME host client pointer.
> > > + * Drivers for MEI devices will get an mei_cl_device pointer
> > > + * when being probed and shall use it for doing ME bus I/O.
> > > + *
> > > + * @dev: linux driver model device pointer
> > > + * @uuid: me client uuid
> > > + * @cl: mei client
> > > + * @priv_data: client private data
> > > + */
> > > +struct mei_cl_device {
> > > +	struct device dev;
> > > +
> > > +	uuid_le uuid;
> > > +	struct mei_cl *cl;
> > > +
> > > +	void *priv_data;
> > > +};
> > 
> > Why is priv_data needed?  What's wrong with the pointer provided to you
> > in struct device?
> mei_cl_device->dev->p->driver_data is used by mei drivers to carry their
> private data around, we define mei_cl_get_clientdata/mei_cl_set_clientdata for
> that and keep the mei_cl_device structure opaque to them.
> mei_cl_device->priv_data is used internally by the drivers/misc/mei/ bus
> related code to carry technology specific pointers. drivers/misc/mei/nfc.c
> uses it to fetch its private data when it gets a mei_cl_device pointer.

Ugh, that looks like a mess, but ok, if you say it is needed, I'll trust
you.

> > > +struct mei_cl_driver {
> > > +	struct device_driver driver;
> > > +	const char *name;
> > 
> > What's wrong with the driver.name field?
> >From your initial comments on patchset v1:
> 
> "
> 	> +static struct mei_bus_driver contact_driver = {
> 	> +     .driver = {
> 	> +                .name = CONTAC_DRIVER_NAME,
> 	> +               },
> 
> 	Can't you put a name field in your mei_bus_driver structure and then
> 	copy it to the version in the driver model?  That's what other bus
> 	drivers do and it makes more sense.
> "
> 
> And you were right, that is indeed what other bus drivers do. Did I
> misunderstand you here ?

No, you are right, sorry for giving conflicting information, it's fine
as-is.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/