RE: [PATCH 2/3] tools: hv: fix checks for origin of netlink messagein hv_vss_daemon

[KY Srinivasan]

> -----Original Message-----
> From: Olaf Hering [mailto:olaf@xxxxxxxxx]
> Sent: Tuesday, March 26, 2013 11:28 AM
> To: KY Srinivasan; gregkh@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Olaf Hering
> Subject: [PATCH 2/3] tools: hv: fix checks for origin of netlink message in
> hv_vss_daemon
> 
> Similar to what commit 95a69adab9acfc3981c504737a2b6578e4d846ef ("tools:
> hv: Netlink source address validation allows DoS") does in
> hv_kvp_daemon, improve checks for origin of netlink connector message.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> ---
>  tools/hv/hv_vss_daemon.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
> index 2a03d0b..dc3eb1e 100644
> --- a/tools/hv/hv_vss_daemon.c
> +++ b/tools/hv/hv_vss_daemon.c
> @@ -186,13 +186,19 @@ int main(void)
>  		len = recvfrom(fd, vss_recv_buffer, sizeof(vss_recv_buffer), 0,
>  				addr_p, &addr_l);
> 
> -		if (len < 0 || addr.nl_pid) {
> +		if (len < 0) {
>  			syslog(LOG_ERR, "recvfrom failed; pid:%u error:%d %s",
>  					addr.nl_pid, errno, strerror(errno));
>  			close(fd);
>  			return -1;
>  		}
> 
> +		if (addr.nl_pid) {
> +			syslog(LOG_WARNING, "Received packet from untrusted
> pid:%u",
> +					addr.nl_pid);
> +			continue;
> +		}
> +
>  		incoming_msg = (struct nlmsghdr *)vss_recv_buffer;
> 
>  		if (incoming_msg->nlmsg_type != NLMSG_DONE)
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/