Re: [PATCH v2.2] dw_dmac: remove unnecessary ENODEV check

From: Viresh Kumar
Date: Tue Mar 26 2013 - 13:31:39 EST


On 26 March 2013 22:59, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> If CONFIG_OF is not set the of_node of the device will always be NULL.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/dma/dw_dmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index 274fd7d..736cffa 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -1846,7 +1846,7 @@ static int dw_probe(struct platform_device *pdev)
> if (pdev->dev.of_node) {
> err = of_dma_controller_register(pdev->dev.of_node,
> dw_dma_of_xlate, dw);
> - if (err && err != -ENODEV)
> + if (err)
> dev_err(&pdev->dev,
> "could not register of_dma_controller\n");

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/