Re: [PATCH v2.1] dw_dmac: make wrapper on of_dma_controller_register()

From: Viresh Kumar
Date: Tue Mar 26 2013 - 13:16:44 EST


On 26 March 2013 22:42, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> Nowadays, besides removal of the -ENODEV checking, it makes probe
> function looks tidier.

Removal of -ENODEV is okay but am not sure if it makes code good :)

This is unnecessary abstraction for just calling a single routine. If that
part was bigger, i would have agreed but to me this wrapper is just
adding abstraction and nothing more.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/