Re: [Suggestion] kernel: 'now' may be used uninitialized in posix_cpu_timer_schedulefunction

From: Chen Gang
Date: Tue Mar 26 2013 - 08:32:57 EST


On 2013å03æ26æ 20:27, Frederic Weisbecker wrote:
> 2013/3/26 Chen Gang <gang.chen@xxxxxxxxxxx>:
>> > Hello Maintainers:
>> >
>> > compiling with EXTRA_CFLAGS=-W:
>> > make V=1 EXTRA_CFLAGS=-W ARCH=arm s3c2410_defconfig
>> > make V=1 EXTRA_CFLAGS=-W ARCH=arm menuconfig
>> > set 'arm-linux-gnu-' for cross chain prefix
>> > make V=1 EXTRA_CFLAGS=-W ARCH=arm
>> >
>> > it will report:
>> > kernel/posix-cpu-timers.c:1065:19: warning: ïnowï may be used uninitialized in this function [-Wuninitialized]
>> >
>> > it seems it is really a bug.
>> > can any member help to fix it ?
>> > or provide additional suggestion ?
>> > (it seems only "unsigned long long now = 0" is not enough).
> Yeah it's missing a call to cpu_timer_sample_group() before
> clear_dead_task(). Andrew Morton reported the warning and I have a
> pending patch to fix that. I'm just checking a few other things before
> sending it. These clear_dead_task() calls seem to also conflict with
> cleanup_timers(). I'm fixing that too.
>
> Thanks for your report!
>
>

thank you, too.

:-)

--
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/