Re: [RFC PATCH v3 3/6] sched: pack small tasks

[Peter Zijlstra]

On Fri, 2013-03-22 at 13:25 +0100, Vincent Guittot wrote:
> +static bool is_buddy_busy(int cpu)
> +{
> +       struct rq *rq = cpu_rq(cpu);
> +
> +       /*
> +        * A busy buddy is a CPU with a high load or a small load with
> a lot of
> +        * running tasks.
> +        */
> +       return (rq->avg.runnable_avg_sum >
> +                       (rq->avg.runnable_avg_period / (rq->nr_running
> + 2)));
> +}

Why does the comment talk about load but we don't see it in the
equation. Also, why does nr_running matter at all? I thought we'd
simply bother with utilization, if fully utilized we're done etc..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/