Re: [PATCH] staging: wlan-ng: prism2usb.c: fix printk(KERN_ERR... topr_err(...

[Greg KH]

On Mon, Mar 25, 2013 at 08:02:28PM +0100, Nick Østergaard wrote:
> Fixed checkpatch.pl warning, changing fix printk(KERN_ERR... to
> pr_err(...
> 
> Signed-off-by: Nick Østergaard <oe.nick@xxxxxxxxx>
> ---
>  drivers/staging/wlan-ng/prism2usb.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
> index b1aed1f..0f2706a 100644
> --- a/drivers/staging/wlan-ng/prism2usb.c
> +++ b/drivers/staging/wlan-ng/prism2usb.c
> @@ -113,14 +113,14 @@ static int prism2sta_probe_usb(struct usb_interface *interface,
>  	dev = interface_to_usbdev(interface);
>  	wlandev = create_wlan();
>  	if (wlandev == NULL) {
> -		printk(KERN_ERR "%s: Memory allocation failure.\n", dev_info);
> +		pr_err("%s: Memory allocation failure.\n", dev_info);

Please use dev_err() instead, as you do have a valid struct device in
which to use.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/