Re: [PATCH] HID: hid-sensor-hub: do not process feature reports inraw_event
From: Srinivas Pandruvada
Date: Mon Mar 25 2013 - 11:41:52 EST
Daniel,
I am looking at 3.9.rc1.
The only place I see the raw_event callback is called from
hid/hid_input_report(). hid_input_report is called with type
HID_INPUT_REPORT in all cases, except hid_ctrl(), where it can be
different depending on xx.report->type. But here, the return value is
not checked.
Do you know the call chain for HID_FETURE_REPORT, where this is creating
problem?
Thanks,
Srinivas
On 03/21/2013 10:22 AM, daniel.leung@xxxxxxxxxxxxxxx wrote:
From: Daniel Leung <daniel.leung@xxxxxxxxxxxxxxx>
In sensor_hub_raw_event(), HID feature reports are ignored but are
still marked as processed. This causes the in-kernel struct not to be
updated. Any non-updated fields in the feature reports are zero, and
they are being sent to the device. This causes confusion in the
sensor hub firmware, and some sensors are not powered up as a result.
This changes the raw_event rountine to only process input reports,
and let the hid core handle the incoming feature reports.
The issue has been observed on Acer Iconia W700.
Signed-off-by: Daniel Leung <daniel.leung@xxxxxxxxxxxxxxx>
---
drivers/hid/hid-sensor-hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index ca749810..3f7df68 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -413,7 +413,7 @@ static int sensor_hub_raw_event(struct hid_device *hdev,
report->id, size, report->type);
hid_dbg(hdev, "maxfield:%d\n", report->maxfield);
if (report->type != HID_INPUT_REPORT)
- return 1;
+ return 0;
ptr = raw_data;
ptr++; /*Skip report id*/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/