Re: [PATCH 03/10] clocksource: sunxi: make use of CLKSRC_OF

[Rob Herring]

On 03/25/2013 08:30 AM, Maxime Ripard wrote:
> Using CLKSRC_OF allows to remove the SoC specific sunxi_timer.h header,
> and instead of using a custom init function in the machine definition
> use the standard clocksource_of_init function.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>

[...]

> @@ -158,3 +157,5 @@ void __init sunxi_timer_init(void)
>  	clockevents_config_and_register(&sunxi_clockevent, rate / TIMER_SCAL,
>  					0x1, 0xff);
>  }
> +CLOCKSOURCE_OF_DECLARE(sunxi, "allwinner,sun4i-timer",
> +		       sunxi_timer_init);

You should base this on clocksource clean-up branch "clksrc/cleanup" in
arm-soc. That will get rid of double matching and match table.

Also, sunxi_timer_init can be static now.

Rob

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/