Re: [PATCH v5 2/2] perf: add sysfs entry to adjust multiplexinginterval per PMU

[Peter Zijlstra]

On Fri, 2013-03-22 at 11:51 +0100, Stephane Eranian wrote:
> In the 4th version, we renamed the sysfs file to be more
> consistent with the other /proc/sys/kernel entries for
> perf_events.

>  static struct device_attribute pmu_dev_attrs[] = {
> -       __ATTR_RO(type),
> -       __ATTR_NULL,
> +       __ATTR_RO(type),
> +       __ATTR_RW(perf_event_mux_interval_ms),
> +       __ATTR_NULL,
>  };

but but but, the file doesn't live in /proc/sys/kernel/, its in
/sys/bus/event_source/devices/*/$foo and none of the files there are
perf_event_* prefixed.

Other than that, the patches look fine.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/