Re: [patch] mm: speedup in __early_pfn_to_nid

[David Rientjes]

On Sat, 23 Mar 2013, KOSAKI Motohiro wrote:

> > --- linux.orig/mm/page_alloc.c  2013-03-19 16:09:03.736450861 -0500
> > +++ linux/mm/page_alloc.c       2013-03-22 17:07:43.895405617 -0500
> > @@ -4161,10 +4161,23 @@ int __meminit __early_pfn_to_nid(unsigne
> >  {
> >         unsigned long start_pfn, end_pfn;
> >         int i, nid;
> > +       /*
> > +          NOTE: The following SMP-unsafe globals are only used early
> > +          in boot when the kernel is running single-threaded.
> > +        */
> > +       static unsigned long last_start_pfn, last_end_pfn;
> > +       static int last_nid;
> 
> Why don't you mark them __meminitdata? They seems freeable.
> 

Um, defining them in a __meminit function places them in .meminit.data 
already.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/