Re: workqueue code needing preemption disabled

[Steven Rostedt]

On Mon, 2013-03-18 at 09:43 -0700, Tejun Heo wrote:

> Making gcwq locks disable preemption would be much safer / easier, but
> if that's not desirable, anything touching gcwq->idle_list would be a
> good place to start - worker_enter_idle() and worker_leave_idle().
> Hmmm... ignoring CPU hotplug, I think those two might just do it.
> Give it a try?  How reproducible is the problem?

Not very :-( I triggered it twice on a 40 CPU box. It can go
approximately 1 month before it triggers. And the box we are testing on
is currently a loaner, and we have it on extension right now. Which
means we wont have it much longer.

But perhaps that's the place to fix things.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/