Re: [PATCH] pm: print the name of failed suspend function forplatform device

From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Fri Mar 15 2013 - 23:53:27 EST



A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Sat, Mar 16, 2013 at 01:22:31AM +0000, Liu, Chuansheng wrote:
> Hello Greg,
>
> Double checked, there is no your response before.
> Can you consider it again? Thanks.

Consider what? I get about 250 patches a _week_, I honestly do not
remember your specific patch, nor do I have it anywhere in front of me.

> Since we have printed the failure info, why not enhance it a bit:)
>
> Example without this patch:
> pm_op(): platform_pm_suspend+0x0/0x50 returns -11
> PM: Device power.0 failed to suspend: error -11
>
> And with this patch:
> platform_pm_suspend(): power_suspend+0x0/0x30 returns -11
> pm_op(): platform_pm_suspend+0x0/0x80 returns -11
> PM: Device power.0 failed to suspend: error -11

Ok, fine, get the PM maintainer to accept the patch then, resend it, cc:
the proper people and it will be considered. If I hate it, I'll tell
you.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/