Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page()

From: Kirill A. Shutemov
Date: Fri Mar 15 2013 - 09:25:23 EST


Hillf Danton wrote:
> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov
> <kirill.shutemov@xxxxxxxxxxxxxxx> wrote:
> > -int split_huge_page(struct page *page)
> > +static int split_anon_huge_page(struct page *page)
> > {
> > struct anon_vma *anon_vma;
> > int ret = 1;
> >
> > - BUG_ON(is_huge_zero_pfn(page_to_pfn(page)));
> > - BUG_ON(!PageAnon(page));
> > -
> deleted, why?

split_anon_huge_page() should only be called from split_huge_page().
Probably I could bring it back, but it's kinda redundant.

--
Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/