Re: [PATCHv2, RFC 09/30] thp, mm: rewrite delete_from_page_cache() tosupport huge pages

From: Kirill A. Shutemov
Date: Fri Mar 15 2013 - 09:22:28 EST


Hillf Danton wrote:
> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov
> <kirill.shutemov@xxxxxxxxxxxxxxx> wrote:
> > + if (PageTransHuge(page)) {
> > + int i;
> > +
> > + for (i = 0; i < HPAGE_CACHE_NR; i++)
> > + radix_tree_delete(&mapping->page_tree, page->index + i);
>
> Move the below page_cache_release for tail page here, please.

Okay. Thanks.

> > + nr = HPAGE_CACHE_NR;
> [...]
> > + if (PageTransHuge(page))
> > + for (i = 1; i < HPAGE_CACHE_NR; i++)
> > + page_cache_release(page + i);
> > page_cache_release(page);

--
Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/