Re: [PATCH v2] usb: Document clocks in samsung,exynos4210-ehci/ohcibindings

From: Jingoo Han
Date: Thu Mar 14 2013 - 23:06:11 EST


On Friday, March 15, 2013 8:01 AM, Doug Anderson wrote:
>
> The exynox4210-ehci and exynos4210-ohci nodes need a clock specified
> using the common clock framework. Document it.
>
> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>

It looks good.
Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx>


Best regards,
Jingoo Han

> ---
> Changes in v2:
> - Fixed embarrassing typo adc=>usb. Thanks Jingoo!
>
> Documentation/devicetree/bindings/usb/exynos-usb.txt | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt
> b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> index f66fcdd..b3abde7 100644
> --- a/Documentation/devicetree/bindings/usb/exynos-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> @@ -10,6 +10,8 @@ Required properties:
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: interrupt number to the cpu.
> + - clocks: from common clock binding: handle to usb clock.
> + - clock-names: from common clock binding: Shall be "usbhost".
>
> Optional properties:
> - samsung,vbus-gpio: if present, specifies the GPIO that
> @@ -22,6 +24,9 @@ Example:
> reg = <0x12110000 0x100>;
> interrupts = <0 71 0>;
> samsung,vbus-gpio = <&gpx2 6 1 3 3>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
>
> OHCI
> @@ -31,10 +36,15 @@ Required properties:
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: interrupt number to the cpu.
> + - clocks: from common clock binding: handle to usb clock.
> + - clock-names: from common clock binding: Shall be "usbhost".
>
> Example:
> usb@12120000 {
> compatible = "samsung,exynos4210-ohci";
> reg = <0x12120000 0x100>;
> interrupts = <0 71 0>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
> --
> 1.8.1.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/