Re: [PATCH v3]Perf: Fix Makefile to clean all object files

[Namhyung Kim]

Hi again,

On Thu, 14 Mar 2013 17:14:28 +0800, chenggang wrote:
> From: Chenggang Qin <chenggang.qcg@xxxxxxxxxx>
>
> If we execute "make clean" in perf's directory, many object files cannot be
> cleaned in the current version.
> For example:
> While we run "make clean" in perf's directory, and run the command:
> "fine ./ -name "*.o""
> we will get:
> ------------------------------------
> ./arch/x86/util/unwind.o
> ./arch/x86/util/header.o
> ./arch/x86/util/dwarf-regs.o
> ./util/scripting-engines/trace-event-python.o
> ./util/scripting-engines/trace-event-perl.o
> ./util/probe-finder.o
> ./util/dwarf-aux.o
> ./util/unwind.o
> ... ...
> ------------------------------------
> These ".o" files are not cleaned.
>
> The reason is:
> These object files are added into "BUILTIN_OBJS" while "make" process check the environment.
> If the make command is "clean", the environment check process is not executed. So,
> these object files will not be added into "BUILTIN_OBJS" while we execute "make clean".

s/BUILTIN/LIB/g

>
> This patch fixed this problem.
> We only add a command:
> "find . -name "*.o" -exec rm -f {} \;"

I think the path should be $(OUTPUT) rather than ".".  How about this?

  find $(OUTPUT) -name "*.o" -delete


Thanks,
Namhyung

>
> Cc: David Ahern <dsahern@xxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx>
> Cc: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxx>
> Cc: Yanmin Zhang <yanmin.zhang@xxxxxxxxx>
> Cc: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> Cc: Mike Galbraith <efault@xxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Chenggang Qin <chenggang.qcg@xxxxxxxxxx>
>
> ---
>  tools/perf/Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index a2108ca..dec08ba 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -1174,6 +1174,7 @@ clean: $(LIBTRACEEVENT)-clean
>  	$(RM) $(OUTPUT)util/*-bison*
>  	$(RM) $(OUTPUT)util/*-flex*
>  	$(python-clean)
> +	$(FIND) . -name "*.o" -exec rm -f {} \;
>  
>  .PHONY: all install clean strip $(LIBTRACEEVENT)
>  .PHONY: shell_compatibility_test please_set_SHELL_PATH_to_a_more_modern_shell
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/