RE: [PATCH RESEND 5/6] Drivers: hv: balloon: Implement hot-addfunctionality

[KY Srinivasan]

> -----Original Message-----
> From: Olaf Hering [mailto:olaf@xxxxxxxxx]
> Sent: Wednesday, March 13, 2013 12:50 PM
> To: KY Srinivasan
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx
> Subject: Re: [PATCH RESEND 5/6] Drivers: hv: balloon: Implement hot-add
> functionality
> 
> On Tue, Mar 12, K. Y. Srinivasan wrote:
> 
> > Implement the memory hot-add functionality. With this, Linux guests can fully
> > participate in the Dynamic Memory protocol implemented in the Windows
> hosts.
> 
> > +++ b/drivers/hv/Kconfig
> > @@ -15,7 +15,7 @@ config HYPERV_UTILS
> >
> >  config HYPERV_BALLOON
> >  	tristate "Microsoft Hyper-V Balloon driver"
> > -	depends on HYPERV
> > +	depends on HYPERV && MEMORY_HOTPLUG
> >  	help
> >  	  Select this option to enable Hyper-V Balloon driver.
> 
> This driver now depends on CONFIG_MEMORY_HOTPLUG, which is disabled in
> openSuSE i386 kernel. As a result, the hv_balloon driver disappears for
> 32bit kernels.
> 
> Any chance that the Kconfig dependency can be moved inside the code so
> that a 32bit guest can still do balloon operations?

I can preserve the old behavior by getting rid of the config dependency and adding in
the MEMORY_HOTPLUG dependency around the affected code. Greg, shall I just re-send
this one patch.

Regards,

K. Y
> 
> 
> Olaf
> 

N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i